Fix user-space data write with incorrect offset #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyWFHuang
force-pushed
the
bug/issue66_write
branch
from
d1ac49a to
99fcabe
Compare
jserv
reviewed
Mar 29, 2025
jserv
requested changes
Mar 29, 2025
RoyWFHuang
force-pushed
the
bug/issue66_write
branch
2 times, most recently
from
df3b0ae to
bcba118
Compare
RoyWFHuang
changed the title
jserv
reviewed
Mar 29, 2025
jserv
requested changes
Mar 29, 2025
RoyWFHuang
force-pushed
the
bug/issue66_write
branch
from
bcba118 to
dc909fb
Compare
The simplefs_write will copy data from user space. If the input length is larger than BLOCK_SIZE, the data will not be copied from user space buffer. close sysprog21#66
RoyWFHuang
force-pushed
the
bug/issue66_write
branch
from
dc909fb to
3abe802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input length is larger than BLOCK_SIZE, the data will not be copied from user space buffer.
"dd" or "print" writes in batches, but "cat" writes the entire data at one.
So we add print and cat commands to test simplefs_write function.
close #66